Skip to content

update dpnp.size to accept tuple of ints for axes #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2025
Merged

update dpnp.size to accept tuple of ints for axes #2536

merged 4 commits into from
Jul 25, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jul 23, 2025

update dpnp.size to accept tuple of ints for axes to align with numpy-2.4

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Jul 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.19.0dev1=py313h509198e_22 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jul 24, 2025 •
edited
Loading

Coverage Status

coverage: 72.101% (+0.002%) from 72.099%
when pulling 28fbbbe on update-size
into f93db81 on master.

@vtavana vtavana marked this pull request as ready for review July 24, 2025 00:46
vlad-perevezentsev
vlad-perevezentsev reviewed Jul 24, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana, LGTM

@vtavana vtavana merged commit 7461016 into master Jul 25, 2025
87 of 92 checks passed
@vtavana vtavana deleted the update-size branch July 25, 2025 13:11
github-actions bot added a commit that referenced this pull request Jul 25, 2025
@github-actions
update dpnp.size to accept tuple of ints for axes (#2536)
bf5e4bd 
update `dpnp.size` to accept tuple of ints for axes to align with numpy-2.4 7461016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vtavana @coveralls @vlad-perevezentsev @antonwolfy